Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add support for non-breaking space #359

Merged
merged 8 commits into from
Apr 17, 2023
Merged

Conversation

sahithyandev
Copy link
Contributor

@sahithyandev sahithyandev commented Jan 8, 2023

fixes #293.

@vercel
Copy link

vercel bot commented Jan 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
satori-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2023 8:48am

@sahithyandev sahithyandev changed the title (WIP) Add support for non-breaking space Add support for non-breaking space Jan 9, 2023
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test case for it? Thanks!

@sahithyandev
Copy link
Contributor Author

I have added a test.

@shuding shuding changed the title Add support for non-breaking space fix: Add support for non-breaking space Apr 17, 2023
@shuding
Copy link
Member

shuding commented Apr 17, 2023

Thanks!

@github-actions
Copy link

🎉 This PR is included in version 0.4.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tvler
Copy link

tvler commented Apr 17, 2023

Thanks for working on this. much appreciated!

sahithyandev added a commit to sahithyandev/satori that referenced this pull request Apr 26, 2024
fixes vercel#293.

---------

Co-authored-by: Shu Ding <g@shud.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Non-breaking space
3 participants