Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#9167): make 1D bars respect orient for stack calculation #9168

Merged
merged 4 commits into from
Nov 8, 2023
Merged

fix(#9167): make 1D bars respect orient for stack calculation #9168

merged 4 commits into from
Nov 8, 2023

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Nov 8, 2023 •
edited
Loading

Fix #9167

@kanitw kanitw changed the title docs(example): bar_1d_dimension only fix(#9167): make 1D bars respect orient for stack calculation Nov 8, 2023
@kanitw kanitw requested review from lsh and fandu-db November 8, 2023 17:36
@kanitw kanitw marked this pull request as ready for review November 8, 2023 17:36
lsh
lsh approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@lsh lsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kanitw kanitw merged commit 432f354 into main Nov 8, 2023
9 checks passed
@kanitw kanitw deleted the kw/9167-stack-1D-bar-dimension-only branch November 8, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsh lsh lsh approved these changes

@fandu-db fandu-db Awaiting requested review from fandu-db

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect stack/orientation for 1D charts
2 participants
@kanitw @lsh