-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow config to set default scale.zero per marktype #8324
Comments
For implementation, you can look at |
Btw, look at existing behavior, I just realize that "always" isn't very accurate. So maybe:
|
If we only have two options, I wonder whether we could consider a Boolean. Otherwise I think all marks, and range marks or bar and area makes sense. I don't think we need to say range marks only. |
FWIW, vega/vega#1471 is related to this. In terms of sequencing, I think add this config in Vega-Lite first would be easier (since it's simpler). |
Some more thoughts:
|
fixed in #8354 |
scale.zero
istrue
as default for x and y channels if the quantitative field is not binned and no custom domain is provided; false otherwise. (https://vega.github.io/vega-lite/docs/scale.html )Though, for some range-based-marktype (e.g., point, box plot).
zero: true
might not be useful default; if the data are mostly distributed 10M~11M and if the scale includes zero, the point marks for those data will look like just a single dot.Even the example scatter plot in VL editor uses zero: false. If we delete it, it looks like this:
--
Suggestion
Assuming that many VL users may be already used to the current default, I would like to suggest adding
config.scale.zero
to change the default instead of changing system default.-> Keep the system defulat:
scale.zero
istrue
as default for x and y channels if the quantitative field is not binned and no custom domain is provided; false otherwise.->
scale.zero
istrue
as default for y(/x) channel if the quantitative field is not binned and no custom domain is provided and it is vertical (/horizontal) bar and area; false otherwise.CC; @kanitw
The text was updated successfully, but these errors were encountered: