Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow all themes from vega themes in types #1288

Merged
merged 2 commits into from
Dec 19, 2023
Merged

fix: allow all themes from vega themes in types #1288

merged 2 commits into from
Dec 19, 2023

Conversation

domoritz
Copy link
Member

No description provided.

lsh
lsh approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@lsh lsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Good catch!

@domoritz
Copy link
Member Author

I discovered it thanks to https://tsdocs.dev/docs/vega-embed/6.23.0/modules.html.

@domoritz domoritz merged commit cab79d2 into main Dec 19, 2023
4 checks passed
@domoritz domoritz deleted the dom/themes-types branch December 19, 2023 18:52
@senalw senalw mentioned this pull request Sep 22, 2024
Closed
@senalw senalw mentioned this pull request Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsh lsh lsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domoritz @lsh