Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support custom IAM role rules #50

Merged
merged 17 commits into from
Jun 24, 2024
Merged

Conversation

ahmad-ibra
Copy link
Collaborator

@ahmad-ibra ahmad-ibra commented Jun 19, 2024

Issue

#39
#12

Description

  • Adds TUI flows for setting up the following aws IAM rules:
    • IamRoleRule
    • IamUserRule
    • IamGroupRule
    • IamPolicyRule
  • Policy documents can be added in either of the methods below:
    • Local path to IAM policy JSON
    • File editor -> opens file editor that they can paste JSON into
  • Removes all palette-aws oriented presets
  • Bumps plugin versions to latest release

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 61.09422% with 128 lines in your changes missing coverage. Please review.

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   55.49%   55.65%   +0.16%     
==========================================
  Files          41       40       -1     
  Lines        4166     4436     +270     
==========================================
+ Hits         2312     2469     +157     
- Misses       1267     1338      +71     
- Partials      587      629      +42     
Files Coverage Δ
pkg/components/validator.go 60.15% <ø> (-0.16%) ⬇️
...integration/_validator/testcases/test_validator.go 94.79% <100.00%> (+0.27%) ⬆️
pkg/services/env_service.go 0.00% <0.00%> (ø)
pkg/cmd/validator/validator.go 59.21% <50.00%> (+0.07%) ⬆️
pkg/services/validator/aws.go 51.57% <56.14%> (+4.33%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aa0810...0dab79f. Read the comment docs.

@ahmad-ibra ahmad-ibra marked this pull request as ready for review June 22, 2024 00:41
@ahmad-ibra ahmad-ibra requested a review from a team as a code owner June 22, 2024 00:41
@ahmad-ibra ahmad-ibra changed the title feat: support custom IAM role rules feat: add support custom IAM role rules Jun 22, 2024
pkg/services/validator/aws.go Outdated Show resolved Hide resolved
pkg/services/validator/aws.go Outdated Show resolved Hide resolved
pkg/services/validator/aws.go Outdated Show resolved Hide resolved
pkg/services/validator/aws.go Show resolved Hide resolved
pkg/services/validator/aws.go Outdated Show resolved Hide resolved
@ahmad-ibra ahmad-ibra merged commit 912c0f3 into main Jun 24, 2024
7 checks passed
@ahmad-ibra ahmad-ibra deleted the chore/remove-aws-presets branch June 24, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants