Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dead code #25

Merged
merged 1 commit into from
Jun 18, 2024
Merged

chore: remove dead code #25

merged 1 commit into from
Jun 18, 2024

Conversation

ahmad-ibra
Copy link
Collaborator

Issue

#4

Description

Removing all dead code from the repo

@ahmad-ibra ahmad-ibra marked this pull request as ready for review June 18, 2024 16:45
@ahmad-ibra ahmad-ibra requested a review from a team as a code owner June 18, 2024 16:45
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   53.30%   53.72%   +0.42%     
==========================================
  Files          41       41              
  Lines        4206     4173      -33     
==========================================
  Hits         2242     2242              
+ Misses       1380     1347      -33     
  Partials      584      584              
Files Coverage Δ
pkg/config/config.go 70.49% <ø> (+4.33%) ⬆️
pkg/logging/logger.go 59.45% <ø> (+3.04%) ⬆️
pkg/services/k8s_service.go 24.44% <ø> (+5.31%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b58097...fdd13f8. Read the comment docs.

@ahmad-ibra ahmad-ibra merged commit 0631a09 into main Jun 18, 2024
7 checks passed
@ahmad-ibra ahmad-ibra deleted the chore/cleanup-unused-func branch June 18, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants