-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Azure plugin community gallery image rule #181
Conversation
Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #181 +/- ##
==========================================
- Coverage 53.56% 53.51% -0.06%
==========================================
Files 44 44
Lines 6228 6296 +68
==========================================
+ Hits 3336 3369 +33
- Misses 2060 2077 +17
- Partials 832 850 +18
Continue to review full report in Codecov by Sentry.
|
Codecov check failing, but it's just because of error conditions our integration tests aren't set up to test yet. |
Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
🤖 I have created a release *beep* *boop* --- ## [0.1.3](v0.1.2...v0.1.3) (2024-09-03) ### Features * inline auth for MAAS ([#198](#198)) ([ed78617](ed78617)) * support Azure plugin community gallery image rule ([#181](#181)) ([3d20725](3d20725)) ### Bug Fixes * ensure ErrValidationFailed is returned for maas direct validation failures ([#179](#179)) ([0e0e7b9](0e0e7b9)) * handle validation errors, result count mismatch ([#204](#204)) ([a2ea08b](a2ea08b)) * only require docker, kind when provisioning kind cluster ([#180](#180)) ([1bbdb0e](1bbdb0e)) * remove duplicate maas base values from template ([#182](#182)) ([cfa39a8](cfa39a8)) * support `validator rules check -f config.yaml` without all plugins defined ([#191](#191)) ([6829834](6829834)) ### Other * cleanup comment ([#176](#176)) ([f371927](f371927)) ### Dependency Updates * **deps:** update anchore/sbom-action action to v0.17.2 ([#184](#184)) ([00d3a5c](00d3a5c)) * **deps:** update github.com/validator-labs/validator-plugin-maas digest to e903cc7 ([#175](#175)) ([09c3ad1](09c3ad1)) * **deps:** update golang.org/x/exp digest to 9b4947d ([#190](#190)) ([8c427e9](8c427e9)) * **deps:** update module github.com/canonical/gomaasclient to v0.7.0 ([#197](#197)) ([f43a5ba](f43a5ba)) * **deps:** update module github.com/validator-labs/validator to v0.1.8 ([#120](#120)) ([fe587c6](fe587c6)) * **deps:** update module github.com/vmware/govmomi to v0.42.0 ([#172](#172)) ([f0488c9](f0488c9)) ### Refactoring * move vsphere account under auth to match new plugin api ([#189](#189)) ([90352e1](90352e1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Issue
Resolves #124
Description
Adds prompts for the Azure community gallery image rule which lets users verify that a particular community image gallery exists within a particular subscription. If it exists, it is accessible by any security principal and Azure system because community image galleries are public.
Also refactors Azure plugin related code to be more like other plugins. Same structure for prompting and no more "RBAC rule type" which must be encoded in the config file and taken into account when re-configuring.