Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to validate the config file #88

Open
Eijebong opened this issue Jun 7, 2021 · 2 comments
Open

Add a way to validate the config file #88

Eijebong opened this issue Jun 7, 2021 · 2 comments

Comments

@Eijebong
Copy link
Contributor

Eijebong commented Jun 7, 2021

Right now there's basically nothing checked on startup and it will panic when vigil starts polling (so basically immediately) if something's wrong.

It'd be nice to have a verification step first so we could include stuff like checking that there's no duplicated id in the config file. (Totally didn't open that because I made this mistake twice already...)

@gbonnefille
Copy link

I've just encoutered something similar: I used a wrong URL for probe (tcp://a.b.c.d:1234/) and I only had a panic, invalid replica_url without anything else. At least the incorrect string would be helpful.

@tomlawesome
Copy link

+1 haven't even got Vigil to launch properly yet because it panicks straight away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants