Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify timestamp handling throughout the stack #1822

Open
benluelo opened this issue Apr 25, 2024 · 1 comment
Open

unify timestamp handling throughout the stack #1822

benluelo opened this issue Apr 25, 2024 · 1 comment
Assignees
Labels
A-voyager Area: Our voyager relayer C-enhancement Category: An issue proposing an enhancement or a PR with one. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. P-medium Medium priority

Comments

@benluelo
Copy link
Contributor

currently, we define timestamps as multiple different types:

/// Query the latest finalized timestamp of this chain.
fn query_latest_timestamp(&self) -> impl Future<Output = Result<i64, Self::Error>> + '_;

pub trait ConsensusState {
fn timestamp(&self) -> u64;
}

this should be unified to a type that handles nanos properly. we can likely reuse the protobuf defined timestamp type: https://github.com/unionlabs/union/blob/main/lib/unionlabs/src/google/protobuf/timestamp.rs

@benluelo benluelo self-assigned this Apr 25, 2024
@benluelo benluelo added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Apr 25, 2024
@benluelo benluelo added E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. A-voyager Area: Our voyager relayer labels Sep 21, 2024
@benluelo
Copy link
Contributor Author

not marking this as E-easy since this touches a significant portion of the repo

@benluelo benluelo added the P-medium Medium priority label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-voyager Area: Our voyager relayer C-enhancement Category: An issue proposing an enhancement or a PR with one. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. P-medium Medium priority
Projects
None yet
Development

No branches or pull requests

1 participant