Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support (loose) string-to-property-map matching in icu_properties #3559

Open
skius opened this issue Jun 21, 2023 · 3 comments
Open

Support (loose) string-to-property-map matching in icu_properties #3559

skius opened this issue Jun 21, 2023 · 3 comments
Assignees
@echeran @sffc @Manishearth
Labels
C-unicode Component: Props, sets, tries discuss Discuss at a future ICU4X-SC meeting discuss-triaged The stakeholders for this issue have been identified and it can be discussed out-of-band
Milestone
Priority Backlog ...

Comments

@skius
Copy link
Member

skius commented Jun 21, 2023

icu_properties does not support obtaining a CodePointMapData (or CodePointSet) from the string of a property name for many properties. It's supported for ECMA-262 binary properties through load_for_ecma_262_unstable, but, e.g., load_word_break cannot be accessed given a string; the client would have to perform property-name-to-icu_properties-functions mapping themselves. Loose matching should also be supported.

UnicodeSet could also support more properties with those features.
@skius skius added C-unicode Component: Props, sets, tries discuss Discuss at a future ICU4X-SC meeting labels Jun 21, 2023
@sffc
Copy link
Member

sffc commented Jun 22, 2023 •
edited
Loading

Discussion: revisit when we have a clearer picture of the set of properties needed by the transliterator.

Discuss with:

Optional:

@Manishearth
Copy link
Member

Yep, when I added the ecma402 function my hope was to potentially add this one as well but we decided to wait for a concrete use case. It does seem like we have one now!

@sffc sffc added the discuss-triaged The stakeholders for this issue have been identified and it can be discussed out-of-band label Jun 22, 2023
This was referenced Aug 3, 2023
Closed
Open
This was referenced Aug 29, 2023
Open
Open
@sffc
Copy link
Member

sffc commented Oct 18, 2023

@makotokato added some additional properties needed for Segmenter data in #4175

@sffc sffc mentioned this issue Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@echeran echeran

@sffc sffc

@Manishearth Manishearth

Labels
C-unicode Component: Props, sets, tries discuss Discuss at a future ICU4X-SC meeting discuss-triaged The stakeholders for this issue have been identified and it can be discussed out-of-band
Projects
None yet
Milestone
Priority Backlog ⟨P3⟩
Development

No branches or pull requests
5 participants
@echeran @sffc @Manishearth @robertbastian @skius