Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devServer): support html asset emit when using writeToDisk #6108

Merged
merged 8 commits into from
Feb 4, 2021

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Feb 1, 2021

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@ycjcl868 ycjcl868 changed the title feat(devServer): support html asset emit using writeToDisk feat(devServer): support html asset emit when using writeToDisk Feb 1, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #6108 (c3a00b1) into master (10b4e02) will increase coverage by 0.14%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6108      +/-   ##
==========================================
+ Coverage   82.94%   83.09%   +0.14%     
==========================================
  Files         158      158              
  Lines        3501     3502       +1     
  Branches      941      942       +1     
==========================================
+ Hits         2904     2910       +6     
+ Misses        588      582       -6     
- Partials        9       10       +1     
Impacted Files Coverage Δ
...c/plugins/commands/build/applyHtmlWebpackPlugin.ts 73.33% <66.66%> (+0.91%) ⬆️
...set-built-in/src/plugins/commands/generateFiles.ts 47.82% <0.00%> (+8.69%) ⬆️
...preset-built-in/src/plugins/features/devScripts.ts 54.16% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b4e02...c3a00b1. Read the comment docs.

@ycjcl868 ycjcl868 changed the title feat(devServer): support html asset emit when using writeToDisk fix(devServer): support html asset emit when using writeToDisk Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants