Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer dependencies rxjs version differs from what angular2 requires. #162

Closed
DavyJohnes opened this issue Oct 29, 2016 · 5 comments
Closed

Comments

@DavyJohnes
Copy link
Contributor

Hi Udo!
ng2-dynamic-forms has peer dependency rxjs: "^5.0.0-rc.1", angular2 (2.1.1) at the same has peer dependency rxjs: "5.0.0-beta.12", It is ok while installing packages, npm warning can be just ignored, but npm shrinkwrap returns an error:
2016-10-29_2258

Is there any reason to use 5.0.0-rc.1?

@udos86
Copy link
Owner

udos86 commented Oct 30, 2016

@DavyJohnes Thanks for the hint! Guess, I was a bit hasty keeping all dependencies up to date to the latest version. Do you think there's a need for a patch in order to make it work with npm shrinkwrap?

@udos86 udos86 added the bug label Oct 30, 2016
@DavyJohnes
Copy link
Contributor Author

DavyJohnes commented Oct 30, 2016

@udos86 I'm almost sure yes. Since one of common usecases is broken.

@udos86
Copy link
Owner

udos86 commented Oct 30, 2016

@DavyJohnes Ok! Does this only affect rxjs or any other dependency?

@DavyJohnes
Copy link
Contributor Author

@udos86 I didn't noticed anything else, but I'd suggest to match peerDependencies with angular's ones.

@udos86
Copy link
Owner

udos86 commented Oct 30, 2016

@DavyJohnes Yep, good suggestion. My mistake!

@udos86 udos86 closed this as completed in a55f654 Oct 30, 2016
@udos86 udos86 added the core label Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants