Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional properties needed for describing labels independent from form controls #700

Closed
seanforyou23 opened this issue Feb 23, 2018 · 3 comments

Comments

@seanforyou23
Copy link
Contributor

seanforyou23 commented Feb 23, 2018

I'm submitting a


[ ] Bug / Regression
[x] Feature Request / Proposal
[ ] Question

I'm using


NG Dynamic Forms Version: `5.4.4`

[ ] Basic UI
[ ] Bootstrap UI  
[ ] Foundation UI
[ ] Ionic UI
[ ] Kendo UI
[ ] Material  
[ ] NG Bootstrap
[ ] Prime NG
[x] Custom UI template

Description

Hello, a common request that comes up when working with forms is the ability to hang helper text off of labels and form controls independently from one another. Explaining what a given label is/means can be very different from describing what types of values or format is expected for a given form control.

As a user of this library, the need for more granular control over how we can describe different aspects of our forms has come up. The request would be to add new properties to facilitate decorating forms with placeholder text, tooltip text for labels, tooltip text for form controls, in addition to the existing "description" property which displays text below a form control.

Having more than a single description property for helper text would allow for more flexibility in the presentation of the model driven forms. If I may, I'd like to recommend adding something like "labelTooltip" or "labelDescription" as well as "controlTooltip" or "controlDescription" in addition to the existing "description" property that already exist. So instead of only having a single option for providing helper text to various aspects of the form, users could take advantage of whichever property fits their needs/designs the best.

I've taken a stab at making this happen in this PR

@kahboom
Copy link

kahboom commented Mar 2, 2018

@udos86 - Any chance we can have this reviewed? We're working on a demo for Red Hat Summit and want to know if we can get this merged in time for the end of the sprint mid-next week, as it will be demoed in front of 6k+ people.

We could just use @seanforyou23 's fork in the project and check in the whole thing, but since other people will be using it as well it would be awesome if we could use it directly from the upstream repo. Thanks and great lib, keep up the work! 👍

@udos86
Copy link
Owner

udos86 commented Mar 2, 2018

@seanforyou23 @kahboom

Hi & thanks for this proposal!

There's a little issue with the PR itself 'cause it does not fully follow the CONTRIBUTING guide.

Could you please branch off of udos86:development and merge back into udos86:development?

I could also cherry-pick your commit but you would not appear as a contributor here, then.

I'd be glad to help you out...

@seanforyou23
Copy link
Contributor Author

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants