Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui-Material : Add mat-hint support to mat-select #608

Closed
rernens opened this issue Nov 26, 2017 · 2 comments · Fixed by #620
Closed

Ui-Material : Add mat-hint support to mat-select #608

rernens opened this issue Nov 26, 2017 · 2 comments · Fixed by #620

Comments

@rernens
Copy link
Contributor

rernens commented Nov 26, 2017

I'm submitting a


[ ] Bug / Regression
[x] Feature Request / Proposal
[ ] Question

I'm using


NG Dynamic Forms Version: `5.0.3+`

[ ] Basic UI
[ ] Bootstrap UI  
[ ] Foundation UI
[ ] Ionic UI
[ ] Kendo UI
[x] Material  5.0.3+
[ ] NG Bootstrap
[ ] Prime NG

Description

it would be nice to have mat-hint support for mat-select field as for mat-input fields.

requires to add

<mat-hint *ngIf="showHint" [innerHTML]="model.hint"></mat-hint>

at line 200 of dynamic-material-form-control.component.html

@rernens rernens changed the title Add mat-hint support to mat-select Ui-Material : Add mat-hint support to mat-select Nov 26, 2017
@udos86
Copy link
Owner

udos86 commented Nov 27, 2017

@rernens Thanks for that proposal!

Would you like to provide a PR for this?

@rernens
Copy link
Contributor Author

rernens commented Nov 28, 2017

@udos86

for sure I'll do that later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants