Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-SemVer tags appropriately #17

Closed
nwiltsie opened this issue Jul 11, 2024 · 2 comments
Closed

Handle non-SemVer tags appropriately #17

nwiltsie opened this issue Jul 11, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@nwiltsie
Copy link
Member

https://github.com/uclahs-cds/docker-BCFtools-score contains multiple tools, so its tagged versions look like v1.20_score-1.20-20240505. Unfortunately with #14 I leaned in to the SemVer styling, so the metadata action throws a fit over that non-standard tag:

Warning: v1.20_score-1.20-20240505 is not a valid semver. More info: https://semver.org/
Warning: No Docker image version has been generated. Check tags input.
Warning: No Docker tag has been generated. Check tags input.

ERROR: tag is needed when pushing to registry

We should be able to handle that case.

@nwiltsie nwiltsie added the bug Something isn't working label Jul 11, 2024
@nwiltsie nwiltsie self-assigned this Jul 11, 2024
@nwiltsie
Copy link
Member Author

Until I manage to get an appropriate global fix for this, individual repositories can work around this issue by passing custom-tags:

jobs:
  push-or-delete-image:
    runs-on: ubuntu-latest
    name: Update GitHub Container Registry
    permissions:
      contents: read
      packages: write
    steps:
      - uses: uclahs-cds/tool-Docker-action@v2.0.0
        with:
          custom-tags: |
            type=match,pattern=v(.*),group=1

@nwiltsie
Copy link
Member Author

Closed by #18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant