Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using a multi-release jar for NullAway #1047

Open
msridhar opened this issue Oct 1, 2024 · 0 comments
Open

Switch to using a multi-release jar for NullAway #1047

msridhar opened this issue Oct 1, 2024 · 0 comments

Comments

@msridhar
Copy link
Collaborator

msridhar commented Oct 1, 2024

We have some code related to JSpecify that invokes JDK 21+ APIs using reflection, as they do not exist on JDK 17 and before. Right now this means we cannot compile NullAway on a javac later than that from JDK 17. We should instead ship NullAway as a multi-release jar. This way we can avoid using reflection on JDK 21+, and we will be able to compile using the latest javac version.

Some guidance on doing multi-release jars with Gradle here. We'll need to update our test tasks for different JDKs carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant