Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbstring is not defined as a platform requirement #164

Closed
punkstar opened this issue Nov 2, 2017 · 0 comments · Fixed by #165
Closed

mbstring is not defined as a platform requirement #164

punkstar opened this issue Nov 2, 2017 · 0 comments · Fixed by #165
Labels

Comments

@punkstar
Copy link
Contributor

punkstar commented Nov 2, 2017

Environment:

  • PHP Version: 7.1.11
  • ICS Parser Version: 2.1.1
  • Linux (Heroku)

Description of the Issue:

When deploying to Heroku I got the following fatal error in the logs:

PHP Fatal error:  Uncaught Error: Call to undefined function ICal\mb_split() in /app/vendor/johngrogg/ics-parser/src/ICal/ICal.php:2026 
Stack trace: 
#0 /app/vendor/johngrogg/ics-parser/src/ICal/ICal.php(2070): ICal\ICal->mb_str_replace('\xC2\x85', Array, 'BEGIN:VCALENDAR') 
#1 /app/vendor/johngrogg/ics-parser/src/ICal/ICal.php(317): ICal\ICal->cleanData('BEGIN:VCALENDAR') 
#2 /app/vendor/johngrogg/ics-parser/src/ICal/ICal.php(245): ICal\ICal->initLines(Array) 
#3 /app/src/Punkstar/RugbyFeed/FixtureProvider/ICal.php(34): ICal\ICal->__construct(Array) 
#4 /app/src/Punkstar/RugbyFeed/FixtureSet.php(19): Punkstar\RugbyFeed\FixtureProvider\ICal->getFixtures() 
#5 /app/src/Punkstar/RugbyFeed/FixtureSet.php(31): Punkstar\RugbyFeed\FixtureSet->getFixtures() 
#6 /app/src/Punkstar/RugbyFeed/League.php(85): Punkstar\RugbyFeed\FixtureSet->getEventsFromTeam(Object(Punkstar\RugbyFeed\Team)) 
#7 /app/src/Punkstar/RugbyFeedService/Controller/FixtureController.php(94): Punkstar\RugbyFeed\League->getFixturesForTeam(Object(Punkstar\RugbyFeed\Team)) 
#8  in /app/vendor/johngrogg/ics-parser/src/ICal/ICal.php on line 2026 

Steps to Reproduce:

You can reproduce by deploying this commit to an app on Heroku: punkstar/rugby-data-api@56c8dfc.

Recommended Fix:

Be explicit about needing the mbstring installed and enabled. I added it as a requirement in my app to get around the problem: punkstar/rugby-data-api@d6db1b2#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780R4.

@u01jmg3 u01jmg3 added the change label Nov 2, 2017
@u01jmg3 u01jmg3 added this to the v2.x.x milestone Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants