Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor suggestion + congratulations #68

Closed
LemosT opened this issue Nov 22, 2014 · 2 comments
Closed

Minor suggestion + congratulations #68

LemosT opened this issue Nov 22, 2014 · 2 comments
Labels

Comments

@LemosT
Copy link

LemosT commented Nov 22, 2014

Hi, there:

First, many thanks for making this extension and publishing it like this! As a way to show my appreciation, I'll be pointing out the location of one small typo that prevents some labels on the backend from being translated: in the config.xml file, around the end, you've written "tranlsate" a few times,
when surely you meant "translate". Hopefully this will help make this awesome extension a little bit better.
Keep up the good work!

@LemosT
Copy link
Author

LemosT commented Nov 22, 2014

Also, might have to change line 151 from Renderer.php to:

$this->_transformOptionsArray[$key] = Mage::helper('easylife_switcher')->__($settings->label);

But still only translated one label.

@tzyganu tzyganu added the bug label Nov 23, 2014
@tzyganu
Copy link
Owner

tzyganu commented Nov 24, 2014

@LemosT Thanks for spotting this. I think I fixed it. If you find any other issues send them my way.

@tzyganu tzyganu closed this as completed Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants