Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoselect first option if none specified #61

Closed
chadrien opened this issue Nov 10, 2014 · 3 comments
Closed

Autoselect first option if none specified #61

chadrien opened this issue Nov 10, 2014 · 3 comments

Comments

@chadrien
Copy link

After a 1 hour fight against the module, I think the Autoselect first option if none specified option should not be hidden if Transform dropdowns to labels is set to None. Those options are not linked and it's only after a long debugging (because some old code from the template looked like it was doing this) I noticed that autoselect_first is returned by the getJsonAdditionalConfig() method. And as the default value is true and the option was hidden in the configuration, I had no clue it came from the Switcher module.

@tzyganu
Copy link
Owner

tzyganu commented Nov 10, 2014

@chadrien. You are right. What was I thinking? It will be fixed soon. Hopefully this week.
Thanks for all the feedback. If you have more, keep it coming.

@chadrien
Copy link
Author

I will for sure! 😉

Very nice module by the way. It's so rare to see some Magento code well written (no rewrite, all observers, etc.) 👍

@tzyganu
Copy link
Owner

tzyganu commented Nov 19, 2014

@chadrien This should be fixed in version 2.0.0

@tzyganu tzyganu closed this as completed Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants