Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checker Framework 3.38.0 gets stuck processing enums #6319

Closed
cushon opened this issue Nov 27, 2023 · 1 comment · Fixed by #6321
Closed

Checker Framework 3.38.0 gets stuck processing enums #6319

cushon opened this issue Nov 27, 2023 · 1 comment · Fixed by #6321
Assignees
Labels

Comments

@cushon
Copy link
Contributor

cushon commented Nov 27, 2023

Version 3.38.0 and newer of the Checker Framework seem to get stuck processing the following example. Earlier versions complete quickly, after 3.38.0 it runs for >15 minutes and appears to be stuck:

import static java.util.Comparator.comparing;
import static java.util.stream.Collectors.toList;

import java.util.List;

class T {
  void f(List<? extends Enum<?>> list) {
    for (Enum<?> value : list.stream().sorted(comparing(Enum::name)).collect(toList())) {}
  }
}
$ javac -fullversion
javac full version "11.0.16+8"
$ javac -J--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED -J--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED -J--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED -J--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED -J--add-exports=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED -J--add-exports=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED -J--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED -J--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED -J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED -processor org.checkerframework.checker.nullness.NullnessChecker -sourcepath : -processorpath checker-framework-3.38.0/checker/dist/checker.jar -cp checker-framework-3.38.0/checker/dist/checker-qual.jar T.java

The stack dump shows many repetitions of these frames:

        at org.checkerframework.framework.util.AtmCombo.accept(AtmCombo.java:612)
        at org.checkerframework.framework.type.DefaultTypeHierarchy.isSubtype(DefaultTypeHierarchy.java:258)
        at org.checkerframework.framework.type.DefaultTypeHierarchy.isContainedBy(DefaultTypeHierarchy.java:411)
        at org.checkerframework.framework.type.DefaultTypeHierarchy.isContainedMany(DefaultTypeHierarchy.java:647)
        at org.checkerframework.framework.type.DefaultTypeHierarchy.visitTypeArgs(DefaultTypeHierarchy.java:607)
        at org.checkerframework.framework.type.DefaultTypeHierarchy.visitDeclared_Declared(DefaultTypeHierarchy.java:550)
        at org.checkerframework.framework.type.DefaultTypeHierarchy.visitDeclared_Declared(DefaultTypeHierarchy.java:48)
        at org.checkerframework.framework.util.AtmCombo.accept(AtmCombo.java:312)
        at org.checkerframework.framework.type.DefaultTypeHierarchy.isSubtype(DefaultTypeHierarchy.java:258)
        at org.checkerframework.framework.type.DefaultTypeHierarchy.isSubtypeCaching(DefaultTypeHierarchy.java:314)
        at org.checkerframework.framework.type.DefaultTypeHierarchy.visitTypevar_Type(DefaultTypeHierarchy.java:1188)
        at org.checkerframework.framework.type.DefaultTypeHierarchy.visitTypevar_Declared(DefaultTypeHierarchy.java:931)
        at org.checkerframework.framework.type.DefaultTypeHierarchy.visitTypevar_Declared(DefaultTypeHierarchy.java:48)
        at org.checkerframework.framework.util.AtmCombo.accept(AtmCombo.java:588)
        at org.checkerframework.framework.type.DefaultTypeHierarchy.isSubtype(DefaultTypeHierarchy.java:258)
        at org.checkerframework.framework.type.DefaultTypeHierarchy.isSubtype(DefaultTypeHierarchy.java:136)
        at org.checkerframework.framework.type.DefaultTypeHierarchy.isContainedWithinBounds(DefaultTypeHierarchy.java:449)        at org.checkerframework.framework.type.DefaultTypeHierarchy.visitTypevar_Typevar(DefaultTypeHierarchy.java:1004)
        at org.checkerframework.framework.type.DefaultTypeHierarchy.visitTypevar_Typevar(DefaultTypeHierarchy.java:48)
@smillst
Copy link
Member

smillst commented Nov 29, 2023

This bug was introduced by 56b1eee.

The test case can be even further simplified to:

 Comparator<Enum<?>> c = Comparator.comparing(Enum::name);

I'll work on fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants