Xamarin Forms 2.0 breaks ViewExtensions

[SmartyP]

I was trying to put the PageViewContainer into a sample app and was having some issues, so I got the full project and tried to use it after updating packages to use Xamarin.Forms 2.0, but I was getting a crash trying to switch between the 3 sample pages.

The issue is in ViewExtensions.cs, the GetRenderer() method and GetRenderDelegate() delegate were previously referencing BindableObject, but have to be changed to VisualElement instead to get it back working without a crash. I figured this out after comparing the Platform.cs in the old and new libraries.

Thanks much for this example!

[georgejecook]

Thanks for looking into that. Switching over to xamarin forms 2.0 is on this weekends agenda.

Sent from my iPhone

On 22 Nov 2015, at 02:23, SmartyP notifications@github.com wrote:

I was trying to put the PageViewContainer into a sample app and was having some issues, so I got the full project and tried to use it after updating packages to use Xamarin.Forms 2.0, but I was getting a crash trying to switch between the 3 sample pages.

The issue is in ViewExtensions.cs, the GetRenderer() method and GetRenderDelegate() delegate were previously referencing BindableObject, but have to be changed to VisualElement instead to get it back working without a crash. I figured this out after comparing the Platform.cs in the old and new libraries.

Thanks much for this example!

—
Reply to this email directly or view it on GitHub.