Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing terminal output should use appropriate fidelity (secs, ms) for easier readability #2246

Closed
e-gineer opened this issue Jul 14, 2022 · 1 comment · Fixed by #2313
Closed
Assignees
Labels
cli output enhancement New feature or request

Comments

@e-gineer
Copy link
Contributor

e-gineer commented Jul 14, 2022

I'm personally finding the very large millisecond values overkill (I don't need that much fidelity) and hard to read (too many digits).

For example, this line:

Time: 1829.5ms. Rows fetched: 59766 (cached). Hydrate calls: 0.

Should be:

Time: 1.8s. Rows fetched: 59,766 (cached). Hydrate calls: 0.

Similarly, it seems like overkill to provide sub-millisecond values.

So this:

Time: 3.3ms.

Should just be:

Time: 3ms.
@e-gineer e-gineer added enhancement New feature or request cli output labels Jul 14, 2022
@e-gineer e-gineer changed the title Timing terminal output should convert to secs instead of milliseconds when large enough Timing terminal output should use appropriate fidelity (secs, ms) for easier readability Jul 14, 2022
@e-gineer
Copy link
Contributor Author

BTW, I recall us discussing doing a common Time: x.yms. to match some other terminal tool. But, in practice, I'm not finding it easy to use or read for our usual data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli output enhancement New feature or request
Projects
None yet
2 participants