Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom loading of wintun.dll should be a feature #75

Closed
cavivie opened this issue Jun 13, 2024 · 5 comments · Fixed by #76
Closed

Custom loading of wintun.dll should be a feature #75

cavivie opened this issue Jun 13, 2024 · 5 comments · Fixed by #76

Comments

@cavivie
Copy link
Collaborator

cavivie commented Jun 13, 2024

Custom loading of wintun.dll should be a feature that can reduce the dependence on libloading.

@cavivie
Copy link
Collaborator Author

cavivie commented Jun 13, 2024

@blechschmidt @ssrlive What do you think?

@ssrlive
Copy link
Member

ssrlive commented Jun 13, 2024

libloading crate is always in the dependencies list. so it's no matter.

@cavivie
Copy link
Collaborator Author

cavivie commented Jun 13, 2024

Forgive me for missing the context, we always use libloading to load wintun.dll, not only when customizing the path. Just close it.

@cavivie cavivie closed this as completed Jun 13, 2024
@cavivie cavivie reopened this Jun 13, 2024
@cavivie
Copy link
Collaborator Author

cavivie commented Jun 13, 2024

However, I think the current platform configuration default value does not obviously point to wintun.dll. Should we specify the default value in the platform configuration instead of replacing a magic str wintun.dll in device mod? In addition, the path parameter of custom_wintun_path should probably point to a string instead of option. If these arguments hold water, then I will make PRs for them.

@ssrlive
Copy link
Member

ssrlive commented Jun 13, 2024

OK. PR welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants