Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unsupported silkscreenpath #63

Merged
merged 4 commits into from
Sep 8, 2024
Merged

Conversation

abhijitxy
Copy link
Contributor

@abhijitxy abhijitxy commented Sep 8, 2024

#45

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment on the modified code says you should only modify it for aliases


expect(silkscreenPaths[0].pcb_silkscreen_path_id).toBeTruthy()

Bun.write("silkscreenpath_test.json", JSON.stringify(silkscreenPaths, null, 2))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Bun.write("silkscreenpath_test.json", JSON.stringify(silkscreenPaths, null, 2))

@abhijitxy abhijitxy merged commit 98f9cdb into tscircuit:main Sep 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants