Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components with custom footprints (explicit smtpads) have a null width and height #93

Closed
seveibar opened this issue Sep 19, 2024 · 4 comments

Comments

@seveibar
Copy link
Contributor

If you go to the tscircuit/cli, run bun run start then download the macrokeypad.tsx circuit json, you'll get null widths/heights in some of the output pcb_components, which messes up some stuff downstream

image

@seveibar
Copy link
Contributor Author

This test has a reproduction if you look at the generated circuit json: https://github.com/tscircuit/core/blob/main/tests/examples/example3-2x2-keyboard.test.tsx

Copy link

homie-gg bot commented Sep 19, 2024

Copy link

homie-gg bot commented Sep 19, 2024

This might have already been done via: fix bounds calculation (null widths).

Copy link

homie-gg bot commented Sep 19, 2024

This might have already been done via: update the parsing of pcb json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant