Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/schematic port #12

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Fix/schematic port #12

merged 3 commits into from
Aug 12, 2024

Conversation

imrishabh18
Copy link
Member

Closes - tscircuit/circuit-to-png#12

  • Adds the schematic_port and parse the text appropriately.
  • Flips the schematic in Y-axis to match the schematic-viewer
Screenshot 2024-08-11 at 2 20 50 AM

@imrishabh18
Copy link
Member Author

@seveibar For the last trace edge to connect to the port, I was debugging but not sure what does the ti in these array mean. If I am not ignoring the ti edge then I am seeing something like this, where the shortest trace is getting added.

Screenshot 2024-08-11 at 2 22 04 AM
Screenshot 2024-08-11 at 2 23 27 AM

@seveibar
Copy link
Contributor

@imrishabh18 I'm not sure what ti means (it might be an abbreviation for "... index"), but I think it's out-of-spec so you can probably ignore it.

As for the line, it seems to me like you're drawing the line path such that it's closing itself, the schematic route paths should never self-close. They may need to connect the first/last segment to the x/y of the port, that I'm not sure of. Looking at the spec to see if there's any details...

@seveibar
Copy link
Contributor

Yea my guess is if the trace isn't touching the port you basically are supposed to manually connect it by searching for the relevant schematic_port's x/y using from_schematic_port_id or to_schematic_port_id

image

@imrishabh18
Copy link
Member Author

Fixed the last trace edge issue @seveibar

Screenshot 2024-08-11 at 6 40 58 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants