From 3c5ce1459cfbb574168d2824e466b004c2d08485 Mon Sep 17 00:00:00 2001 From: dani Date: Fri, 17 May 2024 20:42:20 +0200 Subject: [PATCH] fix model groq empty. change default max tokens. --- src/Providers/Groq/src/GroqChatModel.cs | 1 + src/Providers/Groq/src/GroqConfiguration.cs | 2 +- src/Providers/Groq/src/GroqProvider.cs | 3 +-- src/Providers/Groq/test/GroqTests.cs | 5 +++-- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/Providers/Groq/src/GroqChatModel.cs b/src/Providers/Groq/src/GroqChatModel.cs index 6805fef6..84988e24 100644 --- a/src/Providers/Groq/src/GroqChatModel.cs +++ b/src/Providers/Groq/src/GroqChatModel.cs @@ -18,6 +18,7 @@ public override async Task GenerateAsync( { request = request ?? throw new ArgumentNullException(nameof(request)); var prompt = ToPrompt(request.Messages); + Provider.Api.SetModel(Id); var watch = Stopwatch.StartNew(); var response = await Provider.Api.CreateChatCompletionAsync(prompt).ConfigureAwait(false); diff --git a/src/Providers/Groq/src/GroqConfiguration.cs b/src/Providers/Groq/src/GroqConfiguration.cs index 3a7a7519..b3b30397 100644 --- a/src/Providers/Groq/src/GroqConfiguration.cs +++ b/src/Providers/Groq/src/GroqConfiguration.cs @@ -6,7 +6,7 @@ public class GroqConfiguration public string ApiKey { get; set; } = string.Empty; public string ModelId { get; set; } = string.Empty; public double Temperature { get; set; } = 0.5; - public int MaxTokens { get; set; } = int.MaxValue; + public int MaxTokens { get; set; } = 8192 ; public double TopP { get; set; } = 1.0; public string Stop { get; set; } = "NONE"; public int StructuredRetryPolicy { get; set; } = 5; diff --git a/src/Providers/Groq/src/GroqProvider.cs b/src/Providers/Groq/src/GroqProvider.cs index 06ee5bd0..6d4e2d45 100644 --- a/src/Providers/Groq/src/GroqProvider.cs +++ b/src/Providers/Groq/src/GroqProvider.cs @@ -15,9 +15,8 @@ public GroqProvider(GroqConfiguration configuration) { configuration = configuration ?? throw new ArgumentNullException(nameof(configuration)); var apiKey = configuration.ApiKey ?? throw new ArgumentException("ApiKey is not defined", nameof(configuration)); - var apiModel = configuration.ModelId ?? throw new ArgumentException("ModelId is not defined", nameof(configuration)); - Api = new GroqClient(apiKey, apiModel) + Api = new GroqClient(apiKey, configuration.ModelId) .SetTemperature(configuration.Temperature) .SetMaxTokens(configuration.MaxTokens) .SetTopP(configuration.TopP) diff --git a/src/Providers/Groq/test/GroqTests.cs b/src/Providers/Groq/test/GroqTests.cs index fc8d89db..0fed8ab5 100644 --- a/src/Providers/Groq/test/GroqTests.cs +++ b/src/Providers/Groq/test/GroqTests.cs @@ -12,8 +12,7 @@ public async Task Chat() var config = new GroqConfiguration() { ApiKey = Environment.GetEnvironmentVariable("GROQ_API_KEY") ?? - throw new InconclusiveException("GROQ_API_KEY is not set."), - ModelId = "llama3-70b-8192" + throw new InconclusiveException("GROQ_API_KEY is not set.") }; var provider = new GroqProvider(config); @@ -21,6 +20,8 @@ public async Task Chat() string answer = await model.GenerateAsync("Generate some random name:"); + answer.Should().NotBeNull(); + Console.WriteLine(answer); } }