Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve documentation for new contributors, trussels #402

Merged
merged 5 commits into from
Aug 19, 2020
Merged

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Aug 14, 2020

Summary

Adjust documentation to

  • separate out the release docs from contributing
  • add more detail for new contributors and external contributors specifically
  • include instructions about how to use the library or figure out how to use a component (as per Slack discussions about roadblocks new contributors have faced with styles and passing props to the components)

Related Issues or PRs

closes #377

README.md Outdated Show resolved Hide resolved

This project follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/#summary) specification. This standardizes contributions and streamlines the release flow. **All pull requests opened into `main` must have a title that follows the [conventional commits spec](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional)** This generates an automated changelog entry and is required to merge.
> Note: Currently our CI cannot run directly on external PRs (work from outside the Truss organization) and this prevents merge. To manage this, we pull these PRs into a separate branch that a CODEOWNER creates, run automation, and merge from there. Your initial PR will be closed with a comment and your work will be merged instead from the related PR.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

docs/styles_and_assets.md Outdated Show resolved Hide resolved
@haworku haworku marked this pull request as ready for review August 18, 2020 14:12
Copy link
Contributor

@ahobson ahobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@haworku haworku merged commit 0849a30 into main Aug 19, 2020
@haworku haworku deleted the hw-docs-377 branch August 19, 2020 15:14
@suzubara suzubara mentioned this pull request Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Cleanup docs for new contributors
2 participants