feat(Footer,FooterNav): use size prop, deprecate boolean sizes #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahobson
requested review from
gidjin,
sarboc,
suzubara and
tinyels
as code owners
ahobson
force-pushed
the
adh-footer-prop-enums-233
branch
from
4a9905a
to
6572822
Compare
ahobson
force-pushed
the
adh-footer-prop-enums-233
branch
from
d7c121b
to
bcba4a1
Compare
DanielMiller-agile6
pushed a commit
to DanielMiller-agile6/react-uswds
that referenced
this pull request
Jun 25, 2020
…works#239) * feat(Footer,FooterNav): use size prop, deprecate boolean sizes * fixes trussworks#233 * feat(Footer,FooterNav): update stories for size prop enum
Merged
haworku
pushed a commit
that referenced
this pull request
Jun 29, 2020
* feat(Footer,FooterNav): use size prop, deprecate boolean sizes * fixes #233 * feat(Footer,FooterNav): update stories for size prop enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converts Footer and FooterNav to use size prop with enum
Related Issues or PRs
closes #233