Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Search component should support default value #2206

Closed
1Maria opened this issue Oct 20, 2022 · 2 comments · Fixed by #2211
Closed

[fix] Search component should support default value #2206

1Maria opened this issue Oct 20, 2022 · 2 comments · Fixed by #2211
Labels
type: bug Something isn't working like it's supposed to

Comments

@1Maria
Copy link
Contributor

1Maria commented Oct 20, 2022 •
edited
Loading

ReactUSWDS Version & USWDS Version:

Describe the bug

Cannot add default value to the search component.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Search component story
  2. Add defaultValue prop and value
  3. View in Storybook
  4. See error

Expected behavior

See a default value appear in the search bar

Screenshots

Additional context

Device and Browser Information (please complete the following information if describing a UI bug):
@1Maria 1Maria added the type: bug Something isn't working like it's supposed to label Oct 20, 2022
@1Maria
Copy link
Contributor Author

1Maria commented Oct 20, 2022

I have a PR for this coming

@1Maria 1Maria mentioned this issue Oct 20, 2022
Closed
@haworku
Copy link
Contributor

haworku commented Oct 25, 2022

Thanks for opening this issue! Left a comment on your PR regarding the use case here. #2207 (comment) I wasn't sure if this was the same thing as placeholder or something different.

@gidjin gidjin mentioned this issue Oct 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working like it's supposed to
Projects
None yet
Milestone
No milestone
2 participants
@1Maria @haworku