feat: Add IconPrefix and IconSuffix components #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jenbutongit <hi+git@jen.digital>
brandonlenz
requested review from
ahobson,
gidjin,
haworku,
sarboc,
SirenaBorracha and
suzubara
as code owners
|
The only change I made since the original PR is adding the ability to pass through intrinsic props to the root divs for these elements 0a5d4d1 |
suzubara
approved these changes
Oct 26, 2021
brandonlenz
deleted the
landing-jenbutongit-new-component-InputPrefixSuffix-1235
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR to merge to
main. See #1687 for details and previous code review. The previous pull request was a workaround to allow @jenbutongit to contribute to the repo and hopefully get hacktoberfest credit, while this PR allows us to run the code through our pipeline before merging tomain.