Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused parameter in AnalysisSurfaceIntegral constructor #2033

Open
DanielDoehring opened this issue Aug 8, 2024 · 0 comments · May be fixed by #2069
Open

Unused parameter in AnalysisSurfaceIntegral constructor #2033

DanielDoehring opened this issue Aug 8, 2024 · 0 comments · May be fixed by #2069
Labels
breaking refactoring Refactoring code without functional changes

Comments

@DanielDoehring
Copy link
Contributor

semi in

function AnalysisSurfaceIntegral(semi,
boundary_symbols::NTuple{NBoundaries, Symbol},
variable) where {NBoundaries}
return new{typeof(variable), NBoundaries}(variable, boundary_symbols)
end

is since #1959 not used anymore. I forgot to change the the signature, sorry for this avoidable hazzle.

This should be taken care of in the next breaking release (0.9).

@DanielDoehring DanielDoehring added breaking refactoring Refactoring code without functional changes labels Aug 8, 2024
@DanielDoehring DanielDoehring mentioned this issue Aug 8, 2024
10 tasks
@DanielDoehring DanielDoehring linked a pull request Sep 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking refactoring Refactoring code without functional changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant