Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.79 : LevelMasks could return Borrow #1

Closed
tower120 opened this issue Mar 20, 2024 · 1 comment
Closed

Rust 1.79 : LevelMasks could return Borrow #1

tower120 opened this issue Mar 20, 2024 · 1 comment
Labels
blocked by rust Blocked by lack of compiler feature, which can appear in future enhancement New feature or request

Comments

@tower120
Copy link
Owner

tower120 commented Mar 20, 2024

This rust-lang/rust#122055 should appear in Rust 1.79
We could try to return Borrow in LevelMasks instead of value.
This should allow to remove Clone constraint from BitBlock.

UPDATE. It turns out that we need more robust GAT support from Rust as well. for<'a> does not work in places where we need it.

@tower120 tower120 added enhancement New feature or request blocked by rust Blocked by lack of compiler feature, which can appear in future labels Mar 20, 2024
@tower120 tower120 changed the title Rust 1.79 : LevelMasks could return RefOrVal Rust 1.79 : LevelMasks could return Borrow Mar 22, 2024
@tower120
Copy link
Owner Author

implemented in 'SparseHierarchy' interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked by rust Blocked by lack of compiler feature, which can appear in future enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant