Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount InfoBox content and OverlayView content directly to their respective DOM #93

Closed
thetiby opened this issue Aug 8, 2015 · 5 comments

Comments

@thetiby
Copy link

thetiby commented Aug 8, 2015

Right now, an empty, otherwise useless, div is used to account for the fact that React needs to render to a DOM element. There's actually access to the underlying InfoBox/OverlayView div under instance.div_ which will eliminate the need for that React "crutch".

thetiby referenced this issue Aug 8, 2015
* Also add this support to InfoBox as well
* Only one child is supported inside <InfoWindow> or <InfoBox>
* Closes #69 and thanks to @thetiby
@tomchentw
Copy link
Owner

Thanks for the great discussion and open an issue for me! Will try to add a PR soon :)

@tomchentw
Copy link
Owner

Feel free to submit a PR. Close for now

We're also looking for maintainers. Involve in #266 to help strengthen our community!

@jamesmosier
Copy link

I know this issue is super old, but could you provide some more insight into what the proposed solution is for removing the unneeded div so that something like z-index could be applied to an OverlayView @thetiby ?

I understand that you probably haven't thought about this since the day the issue opened, but I'd love to contribute to fix this but want to make sure I head down the right path.

@thetiby
Copy link
Author

thetiby commented Jul 28, 2018

@Jamez14 you might be able to apply the z-index to the child div that you have control over; if not, check the InfoBoxInstance.div_, if it still exits

@jamesmosier
Copy link

I should've just tried to apply it to the child div from the start 🤦‍♂️ that did it. Thanks @thetiby !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants