Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/intermediate fixes #690

Merged

Conversation

AAverin
Copy link
Contributor

@AAverin AAverin commented Sep 11, 2021

Fixing #347
PR makes sure onStyleLoaded callback is invoked even if didFinishLoading was called before map#waitForMap.

@AAverin
Copy link
Contributor Author

AAverin commented Sep 11, 2021

PR also has inside code from #658 that is required for MapBox to work on iOS.

mikedotalmond added a commit to mikedotalmond/flutter-mapbox-gl that referenced this pull request Sep 23, 2021
@AAverin AAverin mentioned this pull request Oct 4, 2021
Copy link
Collaborator

@shroff shroff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be a good idea to limit PR changes to one feature. Please revert the changes to the podspec and method channel files, and update the PR title to something descriptive of the change before pushing

@felix-ht
Copy link
Collaborator

@AAverin can you address the change requests of shroff so we can this merged?

@AAverin
Copy link
Contributor Author

AAverin commented Oct 15, 2021

@felix-ht Yes, I will take a look once I am back from vacation end of next week.

@AAverin
Copy link
Contributor Author

AAverin commented Oct 21, 2021

@felix-ht I have reverted unrelated changes in this PR.
If it's good to go please merge.

@felix-ht
Copy link
Collaborator

felix-ht commented Nov 4, 2021

LGTM!

@felix-ht felix-ht merged commit 93c00f1 into flutter-mapbox-gl:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants