Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define annotation order #523

Merged
merged 7 commits into from
Feb 12, 2021
Merged

Define annotation order #523

merged 7 commits into from
Feb 12, 2021

Conversation

hwolber
Copy link
Contributor

@hwolber hwolber commented Feb 10, 2021

Hello @tobrun

Here is a merge request regarding an existing issue marked as enhancement:
Circle always on top of Symbols #483

Added an optional list of "AnnotationType" to define the order in which the layers should be added on map.
Whenever the list is not passed in the mapbox widget, the default behavior (already in the current master branch) is applied,
which means the old users of the package can update their project without any action to have their apps running as usual.

Also added an AnnotationOrder example page in the example project of the repo so you can easily test and see the changes.

@andrea689
Copy link
Collaborator

maybe it would be better to use AnnotationType.fill instead of AnnotationType.polygone

@hwolber
Copy link
Contributor Author

hwolber commented Feb 11, 2021

@andrea689 Changed it, now the enum naming is fill not polygone.

Copy link
Collaborator

@andrea689 andrea689 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobrun tobrun merged commit 286d9f8 into flutter-mapbox-gl:master Feb 12, 2021
@hwolber hwolber deleted the define-annotation-order branch February 16, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants