Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wg21 diff thrashing #742

Open
davidlehn opened this issue Apr 25, 2023 · 0 comments
Open

wg21 diff thrashing #742

davidlehn opened this issue Apr 25, 2023 · 0 comments

Comments

@davidlehn
Copy link
Contributor

A couple WG21 refs are trashing back and forth. It makes the commit history a mess. Lots of these, then often flips back next update:
6af3e58

Looks like it's coming from the auto-generated JSON:
https://wg21.link/index.json

If you curl it, it'll change back and forth every so often:
curl https://wg21.link/index.json | jq '.D2652R2,.D2572R1'

There's some extra data in there not used in specref. Will be this:

{
  "type": "paper",
  "title": "Disallow User Specialization of allocator_traits (Bug fix from R1)",
  "subgroup": "",
  "link": "https://wg21.link/d2652r2",
  "long_link": "https://wiki.edg.com/pub/Wg21issaquah2023/StrawPolls/P2652R2.html",
  "source": "https://wiki.edg.com/bin/view/Wg21issaquah2023/StrawPolls"
}
{
  "type": "paper",
  "title": "P2572R1: std::format() fill character allowances",
  "subgroup": "",
  "link": "https://wg21.link/d2572r1",
  "long_link": "https://wiki.edg.com/pub/Wg21issaquah2023/StrawPolls/p2572r1.html",
  "source": "https://wiki.edg.com/bin/view/Wg21issaquah2023/StrawPolls"
}

Or this:

{
  "type": "paper",
  "title": "D2552R2 - Fix `allocator_traits::allocate_at_least`",
  "subgroup": "LWG",
  "link": "https://wg21.link/d2652r2",
  "long_link": "https://wiki.edg.com/pub/Wg21issaquah2023/LibraryWorkingGroup/D2652R2.html",
  "source": "https://wiki.edg.com/bin/view/Wg21issaquah2023/LibraryWorkingGroup"
}
{
  "type": "paper",
  "title": "std::format() fill character allowances",
  "subgroup": "LWG",
  "link": "https://wg21.link/d2572r1",
  "long_link": "https://wiki.edg.com/pub/Wg21issaquah2023/LibraryWorkingGroup/d2572r1.html",
  "source": "https://wiki.edg.com/bin/view/Wg21issaquah2023/LibraryWorkingGroup"
}

I'd guess that whatever is generating that data is pulling from multiple sources (LWG subgroup, and something else) and one entry wins at random. I'm not sure where that data comes from or where a fix should be. If anyone knows, please request a fix. Otherwise, is there a way to mitigate the constant thrashing here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant