Accounting for non standard plugin packages when using plugin-install

[ghost]

Some plugins .zip file decompress in non standard directory (e.g. : zip file for atto_multilang2 decompresses into moodle-atto_multilang2-; mod_hvp decompresses into 2 dir "hvp" and "__MACOSX")

I managed this by unpacking the zip file into the moosh tempdir, and then moving it to the right path with the correct dir name.

Tell me if there is anything wrong with these changes

[tmuras]

1. I don't think we want to clear all downloaded plugins:
   run_external_command("rm -rf $tempdir/*");

what's the reason for this deletion?

2. Please add check if uncompresseddir is a valid directory (it could be that version.php is not found at all)
   $uncompresseddir = exec("find $tempdir -name 'version.php' | rev | cut -d'/' -f 2- | rev");
   run_external_command("mv $uncompresseddir $targetpath");

[ghost]

I removed the deletion of $tempdir content. I needed a clean directory to unpack the plugin to avoid finding the wrong version.php file. I instead create a subdirectory for this purpose.

I thought clearing the $tempdir wouldn't be a problem since the downloaded content was removed after being unpacked anyway.

the check for the validity of uncompresseddir is added

[tmuras]

Thank you very much! I will have a look and merge is very soon.

…

On Thu, 30 May 2024 at 13:32, montanae ***@***.***> wrote: I removed the deletion of $tempdir content. I needed a clean directory to unpack the plugin to avoid finding the wrong version.php file. I instead create a subdirectory for this purpose. I thought clearing the $tempdir wouldn't be a problem since the downloaded content was removed after being unpacked anyway. the check for the validity of uncompresseddir is added — Reply to this email directly, view it on GitHub <#478 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFJX4NEZH65OX4EEBUETYDZE4E6XAVCNFSM6AAAAABIQREFIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZZGM2TOMZQGU> . You are receiving this because you commented.Message ID: ***@***.***>