Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload the current framework when available #24

Closed
tmspzz opened this issue Oct 1, 2016 · 1 comment
Closed

Upload the current framework when available #24

tmspzz opened this issue Oct 1, 2016 · 1 comment

Comments

@tmspzz
Copy link
Owner

tmspzz commented Oct 1, 2016

Rome should be able to also upload the framework build from the current project when
carthage build --platform iOS --no-skip-current is used.

Steps which explain the enhancement

  1. In the Romefile add an optional [Current] section
  2. In the [Current] section add a required currentRepoName = current-framework-name key value pair
  3. Get the version commit hash or tag name from git
  4. rome upload --no-skp-current should look into [Current] to upload a framework.

Current and suggested behavior

  • Currently is it not possible to upload the framework for which the dependencies are being uploaded/downloaded
  • This suggestion aims to fix that

Why would the enhancement be useful to most users

  • It would enable uploading the currently built framework and not only it's dependencies

Rome version: v0.6.1.10
OS and version: Mac OS 10.11.6 - El Capitan

@tmspzz
Copy link
Owner Author

tmspzz commented Nov 9, 2018

Done in #156

@tmspzz tmspzz closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant