Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some boundary lines missing from low zooms #797

Closed
nvkelso opened this issue May 5, 2016 · 6 comments
Closed

Some boundary lines missing from low zooms #797

nvkelso opened this issue May 5, 2016 · 6 comments
Assignees
Labels
Milestone

Comments

@nvkelso
Copy link
Member

nvkelso commented May 5, 2016

  • What did you see? Some state boundary lines are missing at low zooms (zooms 7 and less).
  • What did you expect to see? All boundary lines to show up.
  • What map location are you having problems with? 7/41.307/-121.102 between California, Oregon, Nevada.
  • Screenshot?

Zoom 7, missing some state boundary lines:

screen shot 2016-05-05 at 16 57 23

Zoom 8, all good:

screen shot 2016-05-05 at 16 57 31

@nvkelso nvkelso modified the milestones: v0.10.0, v0.10.1 May 5, 2016
@nvkelso
Copy link
Member Author

nvkelso commented May 6, 2016

@zerebubuth Can you take a look at this, please? We might need to role a v0.10.1 update as this is a regression over v0.9 prod.

@nvkelso nvkelso added the bug label May 6, 2016
@nvkelso
Copy link
Member Author

nvkelso commented May 6, 2016

/cc @sensescape who first reported this.

@nvkelso
Copy link
Member Author

nvkelso commented May 6, 2016

I made a bad assumption about Natural Earth in #687 and #648 (comment) and #517 (comment) :\

The Admin-1 statistical boundary and Admin-1 statistical meta bounds are inclusive of Admin-1 boundaries, not independent. We need to include them as kind:state.

@nvkelso
Copy link
Member Author

nvkelso commented May 6, 2016

screen shot 2016-05-05 at 17 20 54

screen shot 2016-05-05 at 17 20 49

@nvkelso
Copy link
Member Author

nvkelso commented May 6, 2016

@rmarianski Once this lands, we'll need to re-generate zooms 0-7 only for a v0.10.1 release immediately after the v0.10.0 prod tiles cut and before we go live.

@nvkelso
Copy link
Member Author

nvkelso commented May 9, 2016

Dev looked good on Friday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants