-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] RouteInfo Type And Transition.(from|to) #252
Conversation
8131acb
to
05f8ab4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a big diff and I can't pretend to have followed every bit of it, but it all seems reasonable on first read.
How do you plan to mitigate the breakage on the Ember side when we land this there? |
@rwjblue all of this should absorbed by Ember. With the private infos the only thing that might likely troll users is that I renamed the |
05f8ab4
to
4133d4a
Compare
This will likely break liquid-outlet. But that’s fine, the whole point was creating public API to replace the private one it’s using |
This introduces the public
RouteInfo
type andfrom
andto
fields on theTransition
as described in emberjs/rfcs#95.This PR also:
Route
type.HandlerInfo
->RouteInfo
in many places.