transitionTo should return activeTransition when no-op

Transitioning to a route that you're already transitioning to should just return you that currently active transition. Fixes root cause of emberjs/ember.js#10366
tildeio · Mar 26, 2015 · ed45bc5 · ed45bc5
1 parent 5081e7a
commit ed45bc5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/router/router.js b/lib/router/router.js
@@ -43,7 +43,7 @@ function getTransitionByIntent(intent, isIntermediate) {
     }
 
     // No-op. No need to create a new transition.
-    return new Transition(this);
+    return this.activeTransition || new Transition(this);
   }
 
   if (isIntermediate) {

diff --git a/test/tests/router_test.js b/test/tests/router_test.js
@@ -1628,6 +1628,15 @@ asyncTest("Error handling shouldn't trigger for transitions that are already abo
   flushBackburner();
 });
 
+test("Transitions to the same destination as the active transition just return the active transition", function() {
+  expect(1);
+
+  var transition0 = router.handleURL('/index');
+  var transition1 = router.handleURL('/index');
+  equal(transition0, transition1);
+  flushBackburner();
+});
+
 
 test("can redirect from error handler", function() {