Failing test for {{yield}} inside a component that uses the element helper #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cibernox
force-pushed
the
BUG/failing-test-for-yield
branch
from
b51ebaf
to
4196a02
Compare
|
After taking a second look, I found that this only fails if the yielded component receives splattributes, which is even weirder TBH. |
|
Thanks for the report! This is probably a glimmer bug 🤔 I’ll investigate |
|
@chancancode any update on this? |
|
Sorry! I'll check this weekend! |
|
@chancancode shouldn't we wait to close this until new versions of the glimmer-vm are in use by ember? Until then the issue persists. |
|
It just didn't turn out to be related to this add-on at all, and it's an upstream bug, but sure, I can leave this open for now. |
|
@chancancode This can be closed now, Ember 3.4 and 3.7 have been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally got time to check if this helper fixed my needs and I found one case where it doesn't.
Seems that there is a bug when used inside a component and yielding inside the generated element.