Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat(system_launch): add group tag around include #573

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Nov 24, 2022

Signed-off-by: Tomohito Ando tomohito.ando@tier4.jp

PR Type

  • Improvement

Related Links

Description

This change was only applied to tier4/universe branch, so sometimes conflicts happened when doing sync-awf-latest.
I applied this change to awf-latest branch too.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo
Copy link
Contributor Author

@h-ohta Could you check this? 🙏

@TomohitoAndo TomohitoAndo merged commit e497c42 into awf-latest Nov 24, 2022
@TomohitoAndo TomohitoAndo deleted the add-group-tag branch November 24, 2022 06:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants