This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
feat(system_launch): add group tag around include #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
|
I'll merge. |
8 tasks
takayuki5168
pushed a commit
that referenced
this pull request
Jan 21, 2023
* Add external api adaptor (#267) * Add external api adaptor * Add api adaptor to logging simulator Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add engage status output Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add internal api adaptor (#273) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add map hash generator (#319) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add autoware api launch (#326) * Add autoware api launch Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Apply autoware api launch Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add deprecated comment Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove unused parameter (#325) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add api parameter (#341) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add start request API (#321) * Add use start request option Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix lint Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Feature external cmd selector heartbeat (#356) * Rename external command topic Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Modify command topic name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Rename remote_cmd_converter Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove gate mode from external command Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix latest external command name (#361) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix merge conflict Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * change external traffic light topic name in behavior velocity planner (#310) * fix topic * change internal topic name Co-authored-by: yabuta <makoto.yabuta@tier4.jp>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: h-ohta hiroki.ota@tier4.jp
PR Type
Related Links
ros2/launch#620
https://tier4.atlassian.net/browse/T4PB-18074
Description
<include>tag does not scope, so same<arg>tags are overwritten when including multiple launch files.<group>tag around<include>tag.Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks