Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat(autoware_api_launch): add calibration status launcher #332

Merged
merged 16 commits into from
Jun 15, 2022
Merged

feat(autoware_api_launch): add calibration status launcher #332

merged 16 commits into from
Jun 15, 2022

Conversation

TakumiKozaka-T4
Copy link
Contributor

@TakumiKozaka-T4 TakumiKozaka-T4 commented May 26, 2022 •
edited
Loading

PR Type

  • Improvement

Related Links

autowarefoundation/autoware.universe#722

Description

Add calibration status launcher to external ad api adapter.

Review Procedure

Same as the linked PR

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

tier4-autoware-public-bot bot and others added 3 commits May 23, 2022 16:06
@tier4-autoware-public-bot @kenji-miyake
chore: sync awf-latest (#322)
996e9a7 
style: fix flake8 C417 (#321)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
@tier4-autoware-public-bot @kenji-miyake
@h-ohta @TakaHoribe @taikitanaka3 @pre-commit-ci @tkhmy
chore: sync awf-latest (#325)
6ecd000 
* chore: sync files (#311)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* feat: disable namespace `lane_start_bound` (#314)

* feat: disable lane_bound

* fix: lane_start_bound

* feat: add center_line_arrows to disable

* ci: add sync-awf.yaml (#318)

* ci: add sync-awf.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* rename

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* refactor(vehicle_cmd_gate): add namespace (#316)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* style: fix flake8 C417 (#321)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore(behavior_velocity): update latest params (#320)

* chore(behavior_velocity): update latest params

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* ci(pre-commit): autoupdate (#324)

updates:
- [github.com/tier4/pre-commit-hooks-ros: v0.7.0 → v0.7.1](tier4/pre-commit-hooks-ros@v0.7.0...v0.7.1)
- [github.com/scop/pre-commit-shfmt: v3.4.3-1 → v3.5.0-1](scop/pre-commit-shfmt@v3.4.3-1...v3.5.0-1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(autoware_api_launch): add rtc controller (#305)

* add rtc controller

Signed-off-by: tkhmy <tkh.my.p@gmail.com>

* change line

Signed-off-by: tkhmy <tkh.my.p@gmail.com>

* change back to alphabetical order

Signed-off-by: tkhmy <tkh.my.p@gmail.com>

Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kah Hooi Tan <41041286+tkhmy@users.noreply.github.com>
@TakumiKozaka-T4
add calibration status launcher to external_api_adaptor
9d5d8f1 
Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>
@TakumiKozaka-T4 TakumiKozaka-T4 mentioned this pull request May 26, 2022
Merged
7 tasks
kenji-miyake and others added 3 commits May 26, 2022 14:22
@kenji-miyake
Merge branch 'tier4/universe' into sync-awf-latest
571fd76
@kenji-miyake @tier4-autoware-public-bot
@h-ohta @TakaHoribe @taikitanaka3 @pre-commit-ci @tkhmy
chore: sync awf-latest (#331)
df70d96 
* chore: sync files (#311)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* feat: disable namespace `lane_start_bound` (#314)

* feat: disable lane_bound

* fix: lane_start_bound

* feat: add center_line_arrows to disable

* ci: add sync-awf.yaml (#318)

* ci: add sync-awf.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* rename

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* refactor(vehicle_cmd_gate): add namespace (#316)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* style: fix flake8 C417 (#321)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore(behavior_velocity): update latest params (#320)

* chore(behavior_velocity): update latest params

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* ci(pre-commit): autoupdate (#324)

updates:
- [github.com/tier4/pre-commit-hooks-ros: v0.7.0 → v0.7.1](tier4/pre-commit-hooks-ros@v0.7.0...v0.7.1)
- [github.com/scop/pre-commit-shfmt: v3.4.3-1 → v3.5.0-1](scop/pre-commit-shfmt@v3.4.3-1...v3.5.0-1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(autoware_api_launch): add rtc controller (#305)

* add rtc controller

Signed-off-by: tkhmy <tkh.my.p@gmail.com>

* change line

Signed-off-by: tkhmy <tkh.my.p@gmail.com>

* change back to alphabetical order

Signed-off-by: tkhmy <tkh.my.p@gmail.com>

Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kah Hooi Tan <41041286+tkhmy@users.noreply.github.com>
@TakumiKozaka-T4
Merge branch 'awf-latest' of https://github.com/tier4/autoware_launch …
e64c91d 
…into feature/add-calibration-status
@yabuta
Copy link
Contributor

yabuta commented May 26, 2022

@TakumiKozaka-T4 Is ros service added by other PR?

@TakumiKozaka-T4
pull awf-latest
d6ac032 
Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>
@TakumiKozaka-T4
Copy link
Contributor Author

@yabuta

@TakumiKozaka-T4 Is ros service added by other PR?
The additional node includes adapter for both status ros message and calibration data ros service.
Is it better to separate them?

@yabuta
Copy link
Contributor

yabuta commented May 26, 2022

@TakumiKozaka-T4 I see. It is OK as it is

tier4-autoware-public-bot bot and others added 6 commits June 1, 2022 23:51
@tier4-autoware-public-bot @kenji-miyake
@TakaHoribe @wep21 @tkimura4 @YamatoAndo @TomohitoAndo @pre-commit-ci
chore: sync awf-latest (#334)
59fc402 
* chore: sync files (#327)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* refactor: virtual wall rviz config (#326)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* feat(rviz_plugin): adaptive scaling for display size (#329)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix: support context dict key for humble (#328)

* fix: support context dict key for humble

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add todo comment

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* fix: modify type of global parameter (#333)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* chore: sync files (#335)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* feat: use multithread for traffic light container as default (#336)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix(localization_launch): fix input topic name (#338)

* feat(behavior_velocity): add run out module (#339)

* feat(behavior_velocity): add parameter yaml for behavior_velocity_planner

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* feat(behavior_velocity): add run out module

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
Co-authored-by: Yamato Ando <yamato.ando@gmail.com>
Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@h-ohta
fix(mission_planner): disable lane_start_bound in Rviz (#341)
06f3739 
Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
@TomohitoAndo
Merge branch 'tier4/universe' of ssh://github.com/tier4/autoware_laun…
684c19a 
…ch into sync-awf-latest
@TomohitoAndo
Merge pull request #340 from tier4/sync-awf-latest
104714a 
chore: sync awf-latest
@TakumiKozaka-T4
Merge branch 'tier4/universe' of https://github.com/tier4/autoware_la…
23b049b 
…unch into feature/add-calibration-status
@TakumiKozaka-T4
pull the latest tier4/universe
434e2c8 
Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>
@TakumiKozaka-T4 TakumiKozaka-T4 changed the title Add calibration status launcher feat(autoware_api_launch): add calibration status launcher Jun 14, 2022
@TakumiKozaka-T4
Merge branch 'awf-latest' of https://github.com/tier4/autoware_launch …
f5043f4 
…into feature/add-calibration-status
@TakumiKozaka-T4
pull awf-latest
e836db7 
Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>
@TakumiKozaka-T4
fixed unnecessary change.
665b126 
Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>
yabuta
yabuta approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@yabuta yabuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakumiKozaka-T4 TakumiKozaka-T4 merged commit 636c394 into awf-latest Jun 15, 2022
@TakumiKozaka-T4 TakumiKozaka-T4 deleted the feature/add-calibration-status branch June 15, 2022 06:40
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jun 16, 2022
Merged
takayuki5168 pushed a commit that referenced this pull request Jan 21, 2023
@h-ohta
add description for localization_launch (#332)
fab4ee1 
* add description

* fix sentence
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yabuta yabuta yabuta approved these changes

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TakumiKozaka-T4 @yabuta @kenji-miyake @h-ohta @TomohitoAndo