Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): cherry pick PRs for avoidance issue #923

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

satoshi-ota
Copy link

@satoshi-ota satoshi-ota commented Oct 10, 2023

Description

https://tier4.atlassian.net/browse/RT0-29407

cherry pick following two PRs:


Before this PR, since unfeasible (measingless) avoidance path whose shift length is 0.0[m] was output from avoidance module, sometimes the vehicle stucked in front of the objects. In this case, rtc interface doesn't send any avoidance cooperate status.

image

After this PR, avoidance module never outputs unfeasible path. Additionaly, if it is not possible to avoid object, the avoidance module doesn't insert stop point in order to prevent stuck.

image

Tests performed

Test with perception reproducer + rosbag.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…ion#5051)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@takayuki5168 takayuki5168 changed the title hotfix(avoidance): cherry pick PRs for avoidance issue feat(avoidance): cherry pick PRs for avoidance issue Oct 10, 2023
@takayuki5168 takayuki5168 changed the title feat(avoidance): cherry pick PRs for avoidance issue fix(avoidance): cherry pick PRs for avoidance issue Oct 10, 2023
@takayuki5168 takayuki5168 merged commit 0ff5b1f into beta/v0.11.0 Oct 10, 2023
18 of 23 checks passed
@takayuki5168 takayuki5168 deleted the hotfix/avoidance branch October 10, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants