Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_perception_launch): camera lidar fusion launch #833

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

miursh
Copy link

@miursh miursh commented Sep 13, 2023

Description

Hotfix: In order to properly connect the topics, remove unnecessary nodes.

Related links

https://star4.slack.com/archives/CTEJP8L4T/p1694625147360389?thread_ts=1694501199.212649&cid=CTEJP8L4T

Tests performed

Confirmed the prediction object is being output, using logging.simulator.launch in camera_lidar_fusion mode
image

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Copy link

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@miursh 自分のミスをのこしてままで、大変申し訳ありませんでした。ご対応ありがとうございました。

@miursh miursh merged commit 87e9ebf into beta/v0.12.0 Sep 14, 2023
17 checks passed
@miursh miursh deleted the fix/camera_lidar_fusion_launch branch September 14, 2023 01:14
miursh added a commit that referenced this pull request Sep 15, 2023
fix(tier4_perception_launch): camera lidar fusion launch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants