Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hotfix start planner and goal planner #655

Merged

Conversation

1222-takeshi
Copy link

Description

hotfix for beta/v0.8.1-odaiba

Related links

Tests performed

before
https://evaluation.tier4.jp/evaluation/reports/6f16d581-5386-5f3f-a568-d8cb8c904a70?project_id=prd_jt
after
https://evaluation.tier4.jp/evaluation/reports/12388c2f-9093-5a6b-8980-406cb52cb2f5?project_id=prd_jt

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

)

* fix(start_planner): fix path cut by U turn goal

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* cut path

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@1222-takeshi 1222-takeshi changed the title Hotfix/cherry pick start goal planner hotfix: cherry pick start planner and goal planner Jul 10, 2023
@kosuke55
Copy link

@1222-takeshi
ありがとうございます!
どちらも1684/1714なのでマージできそうでしょうか?

Copy link

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much!!

Copy link

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much!!

@1222-takeshi
Copy link
Author

@kosuke55
はい!
大丈夫そうなのでマージしちゃいましょう!

@1222-takeshi 1222-takeshi enabled auto-merge (squash) July 10, 2023 04:34
@1222-takeshi 1222-takeshi changed the title hotfix: cherry pick start planner and goal planner fix: hotfix start planner and goal planner Jul 10, 2023
@1222-takeshi 1222-takeshi merged commit de4e9ae into beta/v0.8.1-odaiba1 Jul 10, 2023
11 of 17 checks passed
@1222-takeshi 1222-takeshi deleted the hotfix/cherry-pick-start-goal-planner branch July 10, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants