Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(behavior_path_planner): simplify calculateDistanceLimit for dynamic drivable area expansion (#4163) #650

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Jul 7, 2023

Description

autowarefoundation#4163
Hotfix to beta/v0.9.0

This PR reduces the cost of running the dynamic drivable area expansion.
Currently, the calculations are very heavy and do not scale well with the number of "uncrossable lines".
This PR improves the performances but do not completely solve the scaling issue.

Related links

https://tier4.atlassian.net/browse/RT0-28451

Tests performed

I checked the frequency of /planning/scenario_planning/lane_driving/behavior_planning/path_with_lane_id in the curved lane.
( I enabled dynamic_expansion and changed extra_footprint_offset from 0.5 to 3.0. )
On my PC (ThinkPad X1 Extreme Gen4), the frequency was 0.2Hz before PR merge, but it becomes >9.9Hz after PR merge.

Notes for reviewers

Interface changes

none

Effects on system behavior

This PR will fix the issue.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…mic drivable area expansion (autowarefoundation#4163)

* Add a test for the calculateDistanceLimit function

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Remove use of boost::geometry::within to improve performance

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* [TMP] run behavior_path_planner with gdb

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Revert "[TMP] run behavior_path_planner with gdb"

This reverts commit b291af4.

---------

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Copy link

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 151a10b into beta/v0.9.0 Jul 7, 2023
25 of 26 checks passed
@tkimura4 tkimura4 deleted the perf/dynamic_expansion-rm_within branch July 7, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants